[llvm] [GlobalISel] Optimize ULEB128 usage (PR #90565)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 05:23:26 PDT 2024


================
@@ -1593,7 +1594,7 @@ void MemoryAlignmentPredicateMatcher::emitPredicateOpcodes(
   Table << MatchTable::Opcode("GIM_CheckMemoryAlignment")
         << MatchTable::Comment("MI") << MatchTable::ULEB128Value(InsnVarID)
         << MatchTable::Comment("MMO") << MatchTable::ULEB128Value(MMOIdx)
-        << MatchTable::Comment("MinAlign") << MatchTable::ULEB128Value(MinAlign)
+        << MatchTable::Comment("MinAlign") << MatchTable::IntValue(1, MinAlign)
----------------
jayfoad wrote:

Maybe assert `MinAlign < 256` somewhere? This is not log alignment, so it would break if some vector load instruction actually required 256-byte or greater alignment.

https://github.com/llvm/llvm-project/pull/90565


More information about the llvm-commits mailing list