[compiler-rt] 0af415d - [compiler-rt][CMake] Do not explicitly set CMP0114 to old (#90386)

via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 15:37:30 PDT 2024


Author: Aiden Grossman
Date: 2024-05-01T15:37:26-07:00
New Revision: 0af415d436e8d352397d3c5b279fca5d9b4e29f5

URL: https://github.com/llvm/llvm-project/commit/0af415d436e8d352397d3c5b279fca5d9b4e29f5
DIFF: https://github.com/llvm/llvm-project/commit/0af415d436e8d352397d3c5b279fca5d9b4e29f5.diff

LOG: [compiler-rt][CMake] Do not explicitly set CMP0114 to old (#90386)

This was added in def0823f1d2db78c4a18b15084407734a45e96c5 to fix a bot
failure, specifically for the standalone build. This does not seem to be
an issue anymore, and setting the policy explicitly to OLD causes
warnings with newer CMake versions.

This patch removes setting the policy to OLD to get rid of the warning.

Added: 
    

Modified: 
    compiler-rt/cmake/Modules/AddCompilerRT.cmake

Removed: 
    


################################################################################
diff  --git a/compiler-rt/cmake/Modules/AddCompilerRT.cmake b/compiler-rt/cmake/Modules/AddCompilerRT.cmake
index 6e0d9dbff65a9e..75b34c8e27e000 100644
--- a/compiler-rt/cmake/Modules/AddCompilerRT.cmake
+++ b/compiler-rt/cmake/Modules/AddCompilerRT.cmake
@@ -2,12 +2,6 @@ include(ExternalProject)
 include(CompilerRTUtils)
 include(HandleCompilerRT)
 
-# CMP0114: ExternalProject step targets fully adopt their steps.
-# New in CMake 3.19: https://cmake.org/cmake/help/latest/policy/CMP0114.html
-if(POLICY CMP0114)
-  cmake_policy(SET CMP0114 OLD)
-endif()
-
 function(set_target_output_directories target output_dir)
   # For RUNTIME_OUTPUT_DIRECTORY variable, Multi-configuration generators
   # append a per-configuration subdirectory to the specified directory.


        


More information about the llvm-commits mailing list