[clang] [clang-tools-extra] [llvm] Add ``ignoringParenImpCasts`` in arguments of hasArgument (PR #89553)

Julian Schmidt via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 12:23:41 PDT 2024


================
@@ -21,9 +21,10 @@ void DurationSubtractionCheck::registerMatchers(MatchFinder *Finder) {
   Finder->addMatcher(
       binaryOperator(
           hasOperatorName("-"),
-          hasLHS(callExpr(callee(functionDecl(DurationConversionFunction())
-                                     .bind("function_decl")),
-                          hasArgument(0, expr().bind("lhs_arg")))))
+          hasLHS(callExpr(
+              callee(functionDecl(DurationConversionFunction())
+                         .bind("function_decl")),
+              hasArgument(0, ignoringParenImpCasts(expr().bind("lhs_arg"))))))
----------------
5chmidti wrote:

This change is not needed, the check does not if implicit nodes are ignored or not, so we don't need to do the extra work.

https://github.com/llvm/llvm-project/pull/89553


More information about the llvm-commits mailing list