[llvm] [ARM/X86] Standardize the isEligibleForTailCallOptimization prototypes (PR #90688)

[Eli Friedman via llvm-commits]

================
@@ -2723,11 +2722,19 @@ bool MatchingStackOffset(SDValue Arg, unsigned Offset, ISD::ArgFlagsTy Flags,
 
 /// Check whether the call is eligible for tail call optimization. Targets
 /// that want to do tail call optimization should implement this function.
+/// Note that musttail calls are not checked for eligibility, so the backend
+/// must support forwarding arguments of any type.
----------------
efriedma-quic wrote:

Oh, I see... in that case, maybe just say that the x86 backend specifically doesn't call this for musttail calls.

(I generally support reporting errors over miscompiling; there are probably arguments either way for structuring this specific part of the code, though.)

https://github.com/llvm/llvm-project/pull/90688