[clang] [llvm] [Driver] Restore compiler-rt arch suffix for PS and Windows (PR #89775)

Paul T Robinson via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 09:15:57 PDT 2024


pogo59 wrote:

Worth noting that this only affects the presumed layout if the driver can't find either layout. In most installations, it will detect which one you have installed, and use it correctly. It's when the driver can't find the libs, and has to guess, that we run into difficulty.

I started out by making additional assumptions based on target, and people didn't like that either.

Another way to run this would be to invent a driver option whose default is derived from the CMake variable (and possibly target), that will pick the presumed layout instead of essentially hardcoding it. Then if you get into situations where the driver is guessing wrong, you have an easy (or at least easier, depending on your build system) fix: add a command-line option.

This is different from the option in #89642 which stops the driver from using the guessed lib name at all, and makes you specify the lib explicitly. My suggestion is an option that tells the driver which layout to use as the fallback.

https://github.com/llvm/llvm-project/pull/89775


More information about the llvm-commits mailing list