[llvm] 0606747 - [AMDGPU] Remove some pointless fallthrough annotations
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Wed May 1 08:08:01 PDT 2024
Author: Jay Foad
Date: 2024-05-01T16:04:35+01:00
New Revision: 0606747c9664b353fe592069c7b00067ba52d832
URL: https://github.com/llvm/llvm-project/commit/0606747c9664b353fe592069c7b00067ba52d832
DIFF: https://github.com/llvm/llvm-project/commit/0606747c9664b353fe592069c7b00067ba52d832.diff
LOG: [AMDGPU] Remove some pointless fallthrough annotations
Added:
Modified:
llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp b/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
index f0c111eaf0600c..4fd9ed2a89279a 100644
--- a/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
+++ b/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
@@ -2342,7 +2342,7 @@ int GCNHazardRecognizer::checkMAIHazards90A(MachineInstr *MI) {
case 8:
NeedWaitStates = SMFMA16x16WritesVGPROverlappedSrcABWaitStates;
break;
- case 16: [[fallthrough]];
+ case 16:
default:
NeedWaitStates = SMFMA32x32WritesVGPROverlappedSrcABWaitStates;
}
diff --git a/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp b/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
index e2e70ba9733b5b..ba01b8513dca7b 100644
--- a/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
+++ b/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp
@@ -376,14 +376,14 @@ static unsigned getOpcodeWidth(const MachineInstr &MI, const SIInstrInfo &TII) {
case AMDGPU::S_BUFFER_LOAD_DWORDX8_SGPR_IMM:
case AMDGPU::S_LOAD_DWORDX8_IMM:
return 8;
- case AMDGPU::DS_READ_B32: [[fallthrough]];
- case AMDGPU::DS_READ_B32_gfx9: [[fallthrough]];
- case AMDGPU::DS_WRITE_B32: [[fallthrough]];
+ case AMDGPU::DS_READ_B32:
+ case AMDGPU::DS_READ_B32_gfx9:
+ case AMDGPU::DS_WRITE_B32:
case AMDGPU::DS_WRITE_B32_gfx9:
return 1;
- case AMDGPU::DS_READ_B64: [[fallthrough]];
- case AMDGPU::DS_READ_B64_gfx9: [[fallthrough]];
- case AMDGPU::DS_WRITE_B64: [[fallthrough]];
+ case AMDGPU::DS_READ_B64:
+ case AMDGPU::DS_READ_B64_gfx9:
+ case AMDGPU::DS_WRITE_B64:
case AMDGPU::DS_WRITE_B64_gfx9:
return 2;
default:
More information about the llvm-commits
mailing list