[llvm] [LoopVectorize] LLVM fails to vectorise loops with multi-bool varables (PR #89226)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 01:28:14 PDT 2024


================
@@ -0,0 +1,794 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4
----------------
fhahn wrote:

> That's a better idea. I'm used to the fabricator days when you couldn't do that!

Splitting the test changes completely off the functional changes has a few advantages compared to adding them as separate commit to this PR:
1. Having a separate PR avoids cluttering the functional review with a large number of comments regarding the tests
2. Github's PR interface shows the changes from all commits in the `Files changed` view
3. As all commits in a PR get squashed together, the commit landing won't just show the diff on the tests caused by the patch, making it more difficult for people looking at the commit later (e.g. when doing post-commit review).

https://github.com/llvm/llvm-project/pull/89226


More information about the llvm-commits mailing list