[llvm] 2cb97c7 - [X86] Add TODO for getTargetConstantFromBasePtr to support non-zero offsets.

[Simon Pilgrim via llvm-commits]

Author: Simon Pilgrim
Date: 2024-04-30T10:43:15+01:00
New Revision: 2cb97c7e29029dc552c66b3ddf6030d826538d47

URL: https://github.com/llvm/llvm-project/commit/2cb97c7e29029dc552c66b3ddf6030d826538d47
DIFF: https://github.com/llvm/llvm-project/commit/2cb97c7e29029dc552c66b3ddf6030d826538d47.diff

LOG: [X86] Add TODO for getTargetConstantFromBasePtr to support non-zero offsets.

As noted on #66991 - we sometimes share vector constant pool entries, referencing subvectors within them via pointer offsets

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 158bf7df07ec3a..859b2682d106c5 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -4639,6 +4639,7 @@ static ConstantPoolSDNode *getTargetConstantPoolFromBasePtr(SDValue Ptr) {
   return dyn_cast<ConstantPoolSDNode>(Ptr);
 }
 
+// TODO: Add support for non-zero offsets.
 static const Constant *getTargetConstantFromBasePtr(SDValue Ptr) {
   ConstantPoolSDNode *CNode = getTargetConstantPoolFromBasePtr(Ptr);
   if (!CNode || CNode->isMachineConstantPoolEntry() || CNode->getOffset() != 0)