[llvm] [llvm-objdump] Error with relevant message when adding invalid notes (PR #90458)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 30 00:52:15 PDT 2024
================
@@ -623,6 +623,58 @@ handleUserSection(const NewSectionInfo &NewSection,
return F(NewSection.SectionName, Data);
}
+static Error verifyNoteSection(StringRef Name, llvm::endianness E,
----------------
jh7370 wrote:
Nit: don't use single-letter variable names for things more complex than a loop counter. Consider `Endianness` instead.
Also, the `llvm::` qualifier is unnecessary. Same elsewhere.
https://github.com/llvm/llvm-project/pull/90458
More information about the llvm-commits
mailing list