[llvm] [GlobalISel] Optimize ULEB128 usage (PR #90565)
Pierre van Houtryve via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 30 00:29:52 PDT 2024
================
@@ -713,6 +713,27 @@ class GIMatchTableExecutor {
memcpy(&Ret, MatchTable, sizeof(Ret));
return Ret;
}
+
+public:
+ // Faster ULEB128 decoder tailored for the Match Table Executor.
+ //
+ // - Arguments are fixed to avoid mid-function checks.
+ // - Unchecked execution, assumes no error.
+ // - Fast common case handling (1 byte values).
+ LLVM_ATTRIBUTE_ALWAYS_INLINE static uint64_t
+ fastDecodeULEB128(const uint8_t *__restrict MatchTable,
----------------
Pierre-vh wrote:
__restrict seems to allow for optimizing away a whole branch. I assume it doesn't reload MatchTable as often because it knows `CurrentIdx` cannot alias it
It probably needs a compiler macro though, I'll look into it
https://github.com/llvm/llvm-project/pull/90565
More information about the llvm-commits
mailing list