[llvm] [Support] Add decodeULEB128AndInc/decodeSLEB128AndInc (PR #85739)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 21:33:07 PDT 2024


dwblaikie wrote:

> (I believe removing default arguments isn't a lot useful as users can always use the existing decodeULEB128 with default arguments)

*nod* I understand. My concern is that this adds friction to users doing error checking-makes it easier to reach for an API that not only doesn't encourage it (the original API) but doesn't allow it - meaning the author has to choose between a more convenient API, and maybe doing error checking - this seems like it'd discourage error checking, which would be unfortunate.

https://github.com/llvm/llvm-project/pull/85739


More information about the llvm-commits mailing list