[lld] [llvm] [Symbolizer] Support for Missing Line Numbers. (PR #82240)
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 29 21:32:00 PDT 2024
================
@@ -1477,10 +1497,11 @@ bool DWARFDebugLine::Prologue::getFileNameByIndex(
}
bool DWARFDebugLine::LineTable::getFileLineInfoForAddress(
- object::SectionedAddress Address, const char *CompDir,
+ object::SectionedAddress Address, const char *CompDir, bool ApproximateLine,
FileLineInfoKind Kind, DILineInfo &Result) const {
// Get the index of row we're looking for in the line table.
- uint32_t RowIndex = lookupAddress(Address);
+ auto RowIndexValue = lookupAddress(Address, ApproximateLine);
----------------
dwblaikie wrote:
Maybe don't use auto and/or use a more descriptive variable name - it's not clear here what this is/what the first/second are (a named structure with named members, as suggested elsewhere, might help too)
https://github.com/llvm/llvm-project/pull/82240
More information about the llvm-commits
mailing list