[llvm] [NFC][llvm-cov]: show supported options for each output format (PR #90519)

Jorge Pinto Sousa via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 13:03:45 PDT 2024


https://github.com/sousajo-cc created https://github.com/llvm/llvm-project/pull/90519

When looking into https://github.com/llvm/llvm-project/issues/85780 one can see:
```
  --format=<value>                   - Output format for line-based coverage reports
    =text                            -   Text output
    =html                            -   HTML output
    =lcov                            -   lcov tracefile output
```

with this patch at least looks clearer from the help what output format can be used.


>From 00765b55472d13899c300fd1d5df66a37e46e004 Mon Sep 17 00:00:00 2001
From: sousajo-cc <jorge.pinto.sousa at protonmail.ch>
Date: Mon, 29 Apr 2024 21:58:30 +0200
Subject: [PATCH] [NFC][llvm-cov]: show supported options for each output
 format

When looking into https://github.com/llvm/llvm-project/issues/85780
one can see:
```
  --format=<value>                   - Output format for line-based coverage reports
    =text                            -   Text output
    =html                            -   HTML output
    =lcov                            -   lcov tracefile output
```

with this patch at least looks clearer from the help what
output format can be used.
---
 llvm/tools/llvm-cov/CodeCoverage.cpp | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/llvm/tools/llvm-cov/CodeCoverage.cpp b/llvm/tools/llvm-cov/CodeCoverage.cpp
index 02448dcd31a161..7d51f017e8b46c 100644
--- a/llvm/tools/llvm-cov/CodeCoverage.cpp
+++ b/llvm/tools/llvm-cov/CodeCoverage.cpp
@@ -666,12 +666,13 @@ int CodeCoverageTool::run(Command Cmd, int argc, const char **argv) {
 
   cl::opt<CoverageViewOptions::OutputFormat> Format(
       "format", cl::desc("Output format for line-based coverage reports"),
-      cl::values(clEnumValN(CoverageViewOptions::OutputFormat::Text, "text",
-                            "Text output"),
-                 clEnumValN(CoverageViewOptions::OutputFormat::HTML, "html",
-                            "HTML output"),
-                 clEnumValN(CoverageViewOptions::OutputFormat::Lcov, "lcov",
-                            "lcov tracefile output")),
+      cl::values(
+          clEnumValN(CoverageViewOptions::OutputFormat::Text, "text",
+                     "Text output"),
+          clEnumValN(CoverageViewOptions::OutputFormat::HTML, "html",
+                     "HTML output (only available with 'show')"),
+          clEnumValN(CoverageViewOptions::OutputFormat::Lcov, "lcov",
+                     "lcov tracefile output (only available with 'export')")),
       cl::init(CoverageViewOptions::OutputFormat::Text));
 
   cl::opt<std::string> PathRemap(



More information about the llvm-commits mailing list