[llvm] [NewPM][CodeGen] Add `MachineFunctionAnalysis` (PR #88610)
Arthur Eubanks via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 29 10:09:37 PDT 2024
================
@@ -129,16 +142,6 @@ class FunctionAnalysisManagerMachineFunctionProxy
Arg.FAM = nullptr;
}
- ~Result() {
- // FAM is cleared in a moved from state where there is nothing to do.
- if (!FAM)
- return;
-
- // Clear out the analysis manager if we're being destroyed -- it means we
- // didn't even see an invalidate call when we got invalidated.
- FAM->clear();
- }
-
----------------
aeubanks wrote:
ah this code was copied from `InnerAnalysisManagerProxy` where an outer IR analysis manager can clear an inner IR analysis manager, which makes sense, but it doesn't make sense for a MachineFunctionAnalysisManager to clear a FunctionAnalysisManager. my bad for this code
https://github.com/llvm/llvm-project/pull/88610
More information about the llvm-commits
mailing list