[llvm] [RemoveDIs] Load into new debug info format by default in LLVM (PR #89799)

[Stephen Tozer via llvm-commits]

================
@@ -1284,6 +1334,11 @@ TEST(Local, ExpressionForConstant) {
 
 TEST(Local, ReplaceDbgVariableRecord) {
   LLVMContext C;
+  // FIXME: PreserveInputDbgFormat is set to true because this test has
+  // been written to expect debug intrinsics rather than debug records; use the
+  // intrinsic format until we update the test checks.
----------------
SLTozer wrote:

I think that with the approach described above, where we only support intrinsics on a best-effort basis, maintaining the convert-from-intrinsic component seems unnecessary to me - I don't mind leaving this test as-is until intrinsics are fully removed. I don't see the specific argument for maintaining the conversion coverage here (rather than testing conversion anywhere else), but if you think it'd be good then I'm happy to leave it in without further justification, since it's essentially 0 cost to maintain.

https://github.com/llvm/llvm-project/pull/89799