[llvm] [llvm-mca] Abort on parse error without -skip-unsupported-instructions (PR #90474)

Peter Waller via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 08:01:55 PDT 2024


peterwaller-arm wrote:

> I understand skipping instructions that lack scheduling information but do we really mean to allow instructions that don’t parse?

One example use case of this is in the exynos test modified by this PR. That one has instructions in the test case which are not supported. Previously, MCA would happily continue to report something anyway. Now that I've changed this not to be default, it's necessary to be able to skip them again to make the test work.

Generally I think this is useful to have. You could find yourself with an assembly you want to analyse which has a rare instruction in it which hasn't yet had LLVM support added, for example if you're using an old version of LLVM at some point in the future and you want to see what MCA would have said if it were not for the unsupported instruction.

https://github.com/llvm/llvm-project/pull/90474


More information about the llvm-commits mailing list