[llvm] [llvm-install-name-tool] Error on non-Mach-O binaries (PR #90351)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 00:51:22 PDT 2024


================
@@ -1242,6 +1243,16 @@ objcopy::parseInstallNameToolOptions(ArrayRef<const char *> ArgsArr) {
   Config.InputFilename = Positional[0];
   Config.OutputFilename = Positional[0];
 
+  Expected<llvm::object::OwningBinary<llvm::object::Binary>> BinaryOrErr =
+      llvm::object::createBinary(Config.InputFilename);
+  if (!BinaryOrErr)
+    return createFileError(Config.InputFilename, BinaryOrErr.takeError());
----------------
jh7370 wrote:

This case should be tested too.

https://github.com/llvm/llvm-project/pull/90351


More information about the llvm-commits mailing list