[llvm] [NFC] Fix comments in PassBuilder functions (PR #89513)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 21 10:24:29 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lto
Author: Ellis Hoag (ellishg)
<details>
<summary>Changes</summary>
The original comments mention `addPreLinkLTODefaultPipeline`, but I could not find any functions with this name, even in https://reviews.llvm.org/D33540 (8b3be4e59d861130746206e41ae42c918bc165df) where this comment was added. I assume they meant to refer to `buildThinLTOPreLinkDefaultPipeline` and `buildLTOPreLinkDefaultPipeline` and so this patch uses them.
---
Full diff: https://github.com/llvm/llvm-project/pull/89513.diff
1 Files Affected:
- (modified) llvm/include/llvm/Passes/PassBuilder.h (+3-3)
``````````diff
diff --git a/llvm/include/llvm/Passes/PassBuilder.h b/llvm/include/llvm/Passes/PassBuilder.h
index c8f643452bb158..9b4da1c466f57d 100644
--- a/llvm/include/llvm/Passes/PassBuilder.h
+++ b/llvm/include/llvm/Passes/PassBuilder.h
@@ -264,12 +264,12 @@ class PassBuilder {
/// the LTO run.
ModulePassManager buildThinLTOPreLinkDefaultPipeline(OptimizationLevel Level);
- /// Build an ThinLTO default optimization pipeline to a pass manager.
+ /// Build a ThinLTO default optimization pipeline to a pass manager.
///
/// This provides a good default optimization pipeline for link-time
/// optimization and code generation. It is particularly tuned to fit well
/// when IR coming into the LTO phase was first run through \c
- /// addPreLinkLTODefaultPipeline, and the two coordinate closely.
+ /// buildThinLTOPreLinkDefaultPipeline, and the two coordinate closely.
ModulePassManager
buildThinLTODefaultPipeline(OptimizationLevel Level,
const ModuleSummaryIndex *ImportSummary);
@@ -288,7 +288,7 @@ class PassBuilder {
/// This provides a good default optimization pipeline for link-time
/// optimization and code generation. It is particularly tuned to fit well
/// when IR coming into the LTO phase was first run through \c
- /// addPreLinkLTODefaultPipeline, and the two coordinate closely.
+ /// buildLTOPreLinkDefaultPipeline, and the two coordinate closely.
ModulePassManager buildLTODefaultPipeline(OptimizationLevel Level,
ModuleSummaryIndex *ExportSummary);
``````````
</details>
https://github.com/llvm/llvm-project/pull/89513
More information about the llvm-commits
mailing list