[llvm] [LLVM][AARCH64]Replace +sme2p1+smef16f16 by +smef16f16 (PR #88860)

Momchil Velikov via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 19 03:01:47 PDT 2024


================
@@ -268,7 +268,7 @@ inline constexpr ExtensionInfo Extensions[] = {
     {"sha3", AArch64::AEK_SHA3, "+sha3", "-sha3", FEAT_SHA3, "+sha3,+sha2,+fp-armv8,+neon", 140},
     {"simd", AArch64::AEK_SIMD, "+neon", "-neon", FEAT_SIMD, "+fp-armv8,+neon", 100},
     {"sm4", AArch64::AEK_SM4, "+sm4", "-sm4", FEAT_SM4, "+sm4,+fp-armv8,+neon", 106},
-    {"sme-f16f16", AArch64::AEK_SMEF16F16, "+sme-f16f16", "-sme-f16f16", FEAT_INIT, "", 0},
+    {"sme-f16f16", AArch64::AEK_SMEF16F16, "+sme-f16f16", "-sme-f16f16", FEAT_INIT, "+sme,+sme-f16f16", 0},
----------------
momchil-velikov wrote:

`FEAT_SME_F16F16` implies `FEAT_SME2`. That dependency is missing here.
It also transitively implies `FEAT_SME` , but that should be picked up in the entry for "sme2" on line 275 and should not be needed here.
Why is "sme-f16f16" in the list of its own dependencies?

https://github.com/llvm/llvm-project/pull/88860


More information about the llvm-commits mailing list