[llvm] [DXIL] Add DXIL SubArch to correspond to version number (PR #89125)

Chris B via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 12:11:07 PDT 2024


llvm-beanz wrote:


> In TripleTest.cpp I don't see any test cases that exercise a specific shadermodel being specified. These are all of the form:
> 
> * dxil-unknown-shadermodel-amplification
> * dxilv1.0-unknown-unknown

We can add those tests, but the LLVM code shouldn't be responsible for this. LLVM should generate the code based on the triple provided or hard error if it can't. That's separate from the shader model version to DXIL version translation which should happen in Clang.

> I can't see anything in this change that does that?
> Is this something that should be done in this PR, or is this happening elsewhere?

This is the requisite LLVM side of the change. We also will need a change to Clang's driver to implement setting the sub architecture as I described.

We could do that in this PR or separately.

https://github.com/llvm/llvm-project/pull/89125


More information about the llvm-commits mailing list