[llvm] Create a CharSetConverter class with both iconv and icu support (PR #74516)
Abhina Sree via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 18 10:30:48 PDT 2024
================
@@ -257,6 +257,37 @@ else()
set(LLVM_ENABLE_TERMINFO 0)
endif()
+#Check for icu.
+if(LLVM_ENABLE_ICU)
+ set(LIBRARY_SUFFIXES ${CMAKE_FIND_LIBRARY_SUFFIXES})
+ set(CMAKE_FIND_LIBRARY_SUFFIXES ".so")
+ if (LLVM_ENABLE_ICU STREQUAL FORCE_ON)
+ find_package(ICU REQUIRED COMPONENTS uc i18n)
+ if (NOT ICU_FOUND)
+ message(FATAL_ERROR "Failed to configure icu, but LLVM_ENABLE_ICU is FORCE_ON")
+ endif()
+ else()
+ find_package(ICU COMPONENTS uc i18n)
+ endif()
+ set(HAVE_ICU ${ICU_FOUND})
+ set(CMAKE_FIND_LIBRARY_SUFFIXES ${LIBRARY_SUFFIXES})
+endif()
+
+# Check for iconv.
+if(LLVM_ENABLE_ICONV)
----------------
abhina-sree wrote:
I think since we are now checking for Iconv_IS_BUILT_IN, we do not need the link step anymore. Please let me know if you think we still need the link step. Thanks!
https://github.com/llvm/llvm-project/pull/74516
More information about the llvm-commits
mailing list