[llvm] [AMDGPU][MC] Separate VOPC MnemonicAlias from Instruction (PR #89105)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 00:20:15 PDT 2024


================
@@ -1386,27 +1386,32 @@ multiclass VOPC_Real_Base<GFXGen Gen, bits<9> op> {
 
 multiclass VOPC_Real_with_name<GFXGen Gen, bits<9> op, string OpName,
                                string asm_name, string pseudo_mnemonic = ""> {
-  let AssemblerPredicate = Gen.AssemblerPredicate, DecoderNamespace = Gen.DecoderNamespace in {
-    defvar ps32 = !cast<VOPC_Pseudo>(OpName#"_e32");
-    defvar ps64 = !cast<VOP3_Pseudo>(OpName#"_e64");
+  defvar ps32 = !cast<VOPC_Pseudo>(OpName#"_e32");
+  defvar ps64 = !cast<VOP3_Pseudo>(OpName#"_e64");
+  let AssemblerPredicate = Gen.AssemblerPredicate in {
----------------
jayfoad wrote:

Just FYI an alternative to splitting this `let` into two would be to add `LetDummies` to the `def`s for the aliases. But this way is fine too.

https://github.com/llvm/llvm-project/pull/89105


More information about the llvm-commits mailing list