[compiler-rt] [test][GWP-ASan] Only add check-gwp_asan when its dependencies are built (PR #89164)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 17 18:57:05 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Wu Yingcong (yingcong-wu)
<details>
<summary>Changes</summary>
Currently, `check-gwp_asan` is added no matter its dependencies are built or not, this is wrong and will cause cmake error when scudo is not built. This patch includes the target in the dependencies check.
---
Full diff: https://github.com/llvm/llvm-project/pull/89164.diff
1 Files Affected:
- (modified) compiler-rt/test/gwp_asan/CMakeLists.txt (+5-5)
``````````diff
diff --git a/compiler-rt/test/gwp_asan/CMakeLists.txt b/compiler-rt/test/gwp_asan/CMakeLists.txt
index 86260027426feb..eda23cd93d6c37 100644
--- a/compiler-rt/test/gwp_asan/CMakeLists.txt
+++ b/compiler-rt/test/gwp_asan/CMakeLists.txt
@@ -35,9 +35,9 @@ if (COMPILER_RT_INCLUDE_TESTS AND COMPILER_RT_HAS_SCUDO_STANDALONE AND COMPILER_
${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME}/lit.site.cfg.py)
list(APPEND GWP_ASAN_TESTSUITES ${CMAKE_CURRENT_BINARY_DIR}/${CONFIG_NAME})
endforeach()
-endif()
-add_lit_testsuite(check-gwp_asan "Running the GWP-ASan tests"
- ${GWP_ASAN_TESTSUITES}
- DEPENDS ${GWP_ASAN_TEST_DEPS})
-set_target_properties(check-gwp_asan PROPERTIES FOLDER "Compiler-RT Misc")
+ add_lit_testsuite(check-gwp_asan "Running the GWP-ASan tests"
+ ${GWP_ASAN_TESTSUITES}
+ DEPENDS ${GWP_ASAN_TEST_DEPS})
+ set_target_properties(check-gwp_asan PROPERTIES FOLDER "Compiler-RT Misc")
+endif()
``````````
</details>
https://github.com/llvm/llvm-project/pull/89164
More information about the llvm-commits
mailing list