[llvm] Convert copy to r-value (PR #89053)

[Chris B via llvm-commits]

================
@@ -168,7 +168,7 @@ void PSVRuntimeInfo::finalize(Triple::EnvironmentType Stage) {
   DXConStrTabBuilder.add(EntryName);
 
   DXConStrTabBuilder.finalize();
-  for (auto ElAndName : zip(SignatureElements, SemanticNames)) {
+  for (auto &&ElAndName : zip(SignatureElements, SemanticNames)) {
----------------
llvm-beanz wrote:

The copy here would just be copying a `std::tuple` of iterators (which are pointers). That doesn’t seem like something that should cause any performance issues, and this doesn’t match other idiomatic use cases of `llvm::zip`.

https://github.com/llvm/llvm-project/pull/89053