[llvm] [RemoveDIs] Update update_test_checks script to recognize dbg_records (PR #87388)

Stephen Tozer via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 03:00:42 PDT 2024


================
@@ -1079,6 +1079,7 @@ def get_value_use(self, var, match, var_prefix=None):
     NamelessValue(r"META", "!", r"", r"![0-9]+", r"(?:distinct |)!.*"),
     NamelessValue(r"ACC_GRP", "!", r"!llvm.access.group ", r"![0-9]+", None),
     NamelessValue(r"META", "!", r"![a-z.]+ ", r"![0-9]+", None),
+    NamelessValue(r"META", "!", r".", r"![0-9]+", None),
----------------
SLTozer wrote:

Regarding brittleness - it would be syntactically correct to include `,` in the prefix expression (`[(, ]`) as well, since it's not a parser error if there is no whitespace betwen arguments(i.e. `!1,!2`), but the assembly writer will never omit the whitespace; since this should only be running on the output of the assembly writer, would you consider it safe/good practice for this tool to only check what will currently be written, and not what could potentially exist in a file?

https://github.com/llvm/llvm-project/pull/87388


More information about the llvm-commits mailing list