[llvm] update_test_checks: match IR basic block labels (PR #88979)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 19:59:52 PDT 2024


Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/88979 at github.com>


nikic wrote:

> Aside from that, the key challenge is that block labels are values, and we typically capture values including the prefix '%'. However, when labels appear at the start of a basic block, the prefix '%' is not included, so we must capture block label values without the prefix '%'.

Just to throw it out there: Might it make sense to generally *not* include the prefix `%` in version 5? That is, use `%[[FOO:.*]]` instead of `[[FOO:%.*]]`?

https://github.com/llvm/llvm-project/pull/88979


More information about the llvm-commits mailing list