[llvm] [DWARF] Clarify a variable name. NFC (PR #88814)

via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 15:59:46 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-debuginfo

Author: Fangrui Song (MaskRay)

<details>
<summary>Changes</summary>

The parameter of `findDebugNamesOffsets` has been renamed to
`EndOfHeaderOffset` in #<!-- -->88064 to make it clear it is a section offset
instead of an offset relative to the current name index. Rename the call
site variable as well.


---
Full diff: https://github.com/llvm/llvm-project/pull/88814.diff


1 Files Affected:

- (modified) llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp (+3-3) 


``````````diff
diff --git a/llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp b/llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp
index 22c9e8cd143c2e..ac19ac79329718 100644
--- a/llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp
+++ b/llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp
@@ -572,12 +572,12 @@ dwarf::findDebugNamesOffsets(uint64_t EndOfHeaderOffset,
 
 Error DWARFDebugNames::NameIndex::extract() {
   const DWARFDataExtractor &AS = Section.AccelSection;
-  uint64_t hdrSize = Base;
-  if (Error E = Hdr.extract(AS, &hdrSize))
+  uint64_t EndOfHeaderOffset = Base;
+  if (Error E = Hdr.extract(AS, &EndOfHeaderOffset))
     return E;
 
   const unsigned SectionOffsetSize = dwarf::getDwarfOffsetByteSize(Hdr.Format);
-  Offsets = dwarf::findDebugNamesOffsets(hdrSize, Hdr);
+  Offsets = dwarf::findDebugNamesOffsets(EndOfHeaderOffset, Hdr);
 
   uint64_t Offset =
       Offsets.EntryOffsetsBase + (Hdr.NameCount * SectionOffsetSize);

``````````

</details>


https://github.com/llvm/llvm-project/pull/88814


More information about the llvm-commits mailing list