[llvm] [TextAPI] Apply NFC code fixups (PR #88639)

Cyndy Ishida via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 13 17:05:25 PDT 2024


https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/88639

* Remove unnecessary cast
* Annotate `#endif`

>From 4d82db336d730167599dc086f20772dd18c833ce Mon Sep 17 00:00:00 2001
From: Cyndy Ishida <cyndy_ishida at apple.com>
Date: Sat, 13 Apr 2024 16:57:55 -0700
Subject: [PATCH] [TextAPI] Apply NFC code fixups

* Remove unecessary cast
* Annotate #endif
---
 llvm/include/llvm/TextAPI/Utils.h             | 2 +-
 llvm/lib/TextAPI/BinaryReader/DylibReader.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/include/llvm/TextAPI/Utils.h b/llvm/include/llvm/TextAPI/Utils.h
index 319e0abce25b03..ebfe88984f8034 100644
--- a/llvm/include/llvm/TextAPI/Utils.h
+++ b/llvm/include/llvm/TextAPI/Utils.h
@@ -21,7 +21,7 @@
 
 #if !defined(PATH_MAX)
 #define PATH_MAX 1024
-#endif
+#endif // !defined(PATH_MAX)
 
 #define MACCATALYST_PREFIX_PATH "/System/iOSSupport"
 #define DRIVERKIT_PREFIX_PATH "/System/DriverKit"
diff --git a/llvm/lib/TextAPI/BinaryReader/DylibReader.cpp b/llvm/lib/TextAPI/BinaryReader/DylibReader.cpp
index f92a2d19a63fc2..ec0271f774ecc5 100644
--- a/llvm/lib/TextAPI/BinaryReader/DylibReader.cpp
+++ b/llvm/lib/TextAPI/BinaryReader/DylibReader.cpp
@@ -484,7 +484,7 @@ accumulateLocs(MachOObjectFile &Obj,
     auto Sym = parseSymbol(Name);
 
     if (!File.empty() && Line != 0)
-      LocMap.insert({Sym.Name.str(), RecordLoc(File, Line)});
+      LocMap.insert({Sym.Name, RecordLoc(File, Line)});
   }
 
   return LocMap;



More information about the llvm-commits mailing list