[lldb] [llvm] Add support for using foreign type units in .debug_names. (PR #87740)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 12 14:35:40 PDT 2024


================
@@ -58,6 +58,8 @@ class DWARFDebugInfo {
 
   const DWARFDebugAranges &GetCompileUnitAranges();
 
+  const std::shared_ptr<SymbolFileDWARFDwo> GetDwpSymbolFile();
----------------
dwblaikie wrote:

Remove const from by-value return. (it messes with move semantics and some other things) - or was this meant to return by reference? - yeah, I guess this latter, the underlying `m_dwarf.GetDwpSymbolFile()` seems to return by const reference, so this function probably should too?

https://github.com/llvm/llvm-project/pull/87740


More information about the llvm-commits mailing list