[llvm] [LoongArch] Return true from shouldConsiderGEPOffsetSplit (PR #88371)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 12 01:28:03 PDT 2024
https://github.com/wangleiat updated https://github.com/llvm/llvm-project/pull/88371
>From dcbf6de80feb2c84d9ad8d7e645bb101894ca417 Mon Sep 17 00:00:00 2001
From: wanglei <wanglei at loongson.cn>
Date: Thu, 11 Apr 2024 17:01:08 +0800
Subject: [PATCH] [LoongArch] Return true from shouldConsiderGEPOffsetSplit
If not performing gep splits can prevent important optimizations, such
as preventing the element indices / member offsets from being
(partially) folded into load/store instruction immediates.
---
.../Target/LoongArch/LoongArchISelLowering.h | 1 +
.../CodeGenPrepare/LoongArch/lit.local.cfg | 2 ++
.../CodeGenPrepare/LoongArch/splitgep.ll | 34 +++++++++++++++++++
3 files changed, 37 insertions(+)
create mode 100644 llvm/test/Transforms/CodeGenPrepare/LoongArch/lit.local.cfg
create mode 100644 llvm/test/Transforms/CodeGenPrepare/LoongArch/splitgep.ll
diff --git a/llvm/lib/Target/LoongArch/LoongArchISelLowering.h b/llvm/lib/Target/LoongArch/LoongArchISelLowering.h
index 9e9ac0b8269291..4bb6c049f8d758 100644
--- a/llvm/lib/Target/LoongArch/LoongArchISelLowering.h
+++ b/llvm/lib/Target/LoongArch/LoongArchISelLowering.h
@@ -238,6 +238,7 @@ class LoongArchTargetLowering : public TargetLowering {
bool isShuffleMaskLegal(ArrayRef<int> Mask, EVT VT) const override {
return false;
}
+ bool shouldConsiderGEPOffsetSplit() const override { return true; }
private:
/// Target-specific function used to lower LoongArch calling conventions.
diff --git a/llvm/test/Transforms/CodeGenPrepare/LoongArch/lit.local.cfg b/llvm/test/Transforms/CodeGenPrepare/LoongArch/lit.local.cfg
new file mode 100644
index 00000000000000..cc24278acbb414
--- /dev/null
+++ b/llvm/test/Transforms/CodeGenPrepare/LoongArch/lit.local.cfg
@@ -0,0 +1,2 @@
+if not "LoongArch" in config.root.targets:
+ config.unsupported = True
diff --git a/llvm/test/Transforms/CodeGenPrepare/LoongArch/splitgep.ll b/llvm/test/Transforms/CodeGenPrepare/LoongArch/splitgep.ll
new file mode 100644
index 00000000000000..20cc25e95adf97
--- /dev/null
+++ b/llvm/test/Transforms/CodeGenPrepare/LoongArch/splitgep.ll
@@ -0,0 +1,34 @@
+; RUN: opt --mtriple=loongarch64 -S --passes='require<profile-summary>,function(codegenprepare)' %s | FileCheck %s
+
+; Check that we have deterministic output
+define void @test(ptr %sp, ptr %t, i32 %n) {
+; CHECK-LABEL: @test(
+; CHECK-NEXT: entry:
+; CHECK-NEXT: %splitgep1 = getelementptr i8, ptr %t, i64 80000
+; CHECK-NEXT: %s = load ptr, ptr %sp
+; CHECK-NEXT: %splitgep = getelementptr i8, ptr %s, i64 80000
+entry:
+ %s = load ptr, ptr %sp
+ br label %while_cond
+
+while_cond:
+ %phi = phi i32 [ 0, %entry ], [ %i, %while_body ]
+ %gep0 = getelementptr [65536 x i32], ptr %s, i64 0, i64 20000
+ %gep1 = getelementptr [65536 x i32], ptr %s, i64 0, i64 20001
+ %gep2 = getelementptr [65536 x i32], ptr %t, i64 0, i64 20000
+ %gep3 = getelementptr [65536 x i32], ptr %t, i64 0, i64 20001
+ %cmp = icmp slt i32 %phi, %n
+ br i1 %cmp, label %while_body, label %while_end
+
+while_body:
+ %i = add i32 %phi, 1
+ store i32 %i, ptr %gep0
+ store i32 %phi, ptr %gep1
+ store i32 %i, ptr %gep2
+ store i32 %phi, ptr %gep3
+ br label %while_cond
+
+while_end:
+ ret void
+}
+
More information about the llvm-commits
mailing list