[llvm] [DSE] Fix non-determinism due to address reuse (PR #84943)

[Nikita Popov via llvm-commits]

================
@@ -2221,7 +2226,7 @@ static bool eliminateDeadStores(Function &F, AliasAnalysis &AA, MemorySSA &MSSA,
           continue;
         LLVM_DEBUG(dbgs() << "DSE: Remove Dead Store:\n  DEAD: " << *DeadI
                           << "\n  KILLER: " << *KillingI << '\n');
-        State.deleteDeadInstruction(DeadI);
+        State.deleteDeadInstruction(DeadI, &Deleted);
----------------
nikic wrote:

I've added an assertion -- does that match what you had in mind?

https://github.com/llvm/llvm-project/pull/84943