[llvm] [VPlan] Track VPValue names in VPlan. (PR #81411)

via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 00:21:21 PDT 2024


ayalz wrote:

> I completely reworked the patch to now *only* perform de-duplication in `VPSlotTracker`, without changing anything else besides `printAsOperand` to use `VPSlotTracker::getName` to obtain a possibly de-duplicated name for a VPValue.
> 
> 
> 
> This should be sufficient to unblock VPlan2VPlan interleaving.
> 
> 
> 
> WDYT?

Looks good to me, with various minor comments.

> of VPlan only: w/o delegating to names of IR Values when generating them,

Actually, it appears the (two listed VPInstruction) names do not even propagate to VPlan's debug printings, i.e., they are totally unused and should be dce'd.

https://github.com/llvm/llvm-project/pull/81411


More information about the llvm-commits mailing list