[llvm] [AArch64] Fix to Neoverse V2 scheduling model (PR #88130)

Maciej Gabka via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 10 01:30:59 PDT 2024


mgabka wrote:

> Is adding a test for this is difficult, as it doesn't modify much in practice? The change sounds sensible.

Yeah, to me looks like this value does not impact much, in most cases it is just checked if it is !=0 or ==1, the only one place I found where the actual value matters is here https://github.com/llvm/llvm-project/blob/4e85e1ffcaf161736e27a24c291c1177be865976/llvm/lib/CodeGen/MachineScheduler.cpp#L3360 , 

that code seems to be added by https://github.com/llvm/llvm-project/commit/c01b00400d85342fe365995269fa8c7182f1b440 and the EnableCyclicPath is now by defult true, but setting it to false does not break any tests for me.

https://github.com/llvm/llvm-project/pull/88130


More information about the llvm-commits mailing list