[llvm] 892f01a - Remove the assertion to unblock breakages (#88035)

via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 18:53:12 PDT 2024


Author: Lei Wang
Date: 2024-04-09T18:53:09-07:00
New Revision: 892f01a7437b20f5df3edf53824a53889f733b06

URL: https://github.com/llvm/llvm-project/commit/892f01a7437b20f5df3edf53824a53889f733b06
DIFF: https://github.com/llvm/llvm-project/commit/892f01a7437b20f5df3edf53824a53889f733b06.diff

LOG: Remove the assertion to unblock breakages (#88035)

as titled.

Added: 
    

Modified: 
    llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h b/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
index 581d354fc4766c..39295d6d81b8f9 100644
--- a/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
+++ b/llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
@@ -140,13 +140,9 @@ class PseudoProbeManager {
     // be 
diff erent and result in 
diff erent checksums. So we should use the
     // state from the new (available_externally) function, which is saved in its
     // attribute.
-    assert((LTOPhase != ThinOrFullLTOPhase::ThinLTOPostLink ||
-            IsAvailableExternallyLinkage || !Desc ||
-            profileIsHashMismatched(*Desc, Samples) ==
-                F.hasFnAttribute("profile-checksum-mismatch")) &&
-           "In post-link, profile checksum matching state doesn't match the "
-           "internal function's 'profile-checksum-mismatch' attribute.");
-    (void)LTOPhase;
+    // TODO: If the function's profile only exists as nested inlinee profile in
+    // a 
diff erent module, we don't have the attr mismatch state(unknown), we
+    // need to fix it later.
     if (IsAvailableExternallyLinkage || !Desc)
       return !F.hasFnAttribute("profile-checksum-mismatch");
 


        


More information about the llvm-commits mailing list