[llvm] [ThinLTO]Record import type in GlobalValueSummary::GVFlags (PR #87597)

Jan Voung via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 17:39:57 PDT 2024


================
@@ -635,7 +635,8 @@ static void computeFunctionSummary(
                               HasIndirBranchToBlockAddress || HasIFuncCall;
   GlobalValueSummary::GVFlags Flags(
       F.getLinkage(), F.getVisibility(), NotEligibleForImport,
-      /* Live = */ false, F.isDSOLocal(), F.canBeOmittedFromSymbolTable());
+      /* Live = */ false, F.isDSOLocal(), F.canBeOmittedFromSymbolTable(),
+      /*ImportType=*/GlobalValueSummary::ImportKind::Definition);
----------------
jvoung wrote:

nit: I think you removed from the comment from other cases in this file already, but now that it's an enum and not "false" the comment seems less important 

same in "makeDummyFunctionSummary" in the ModuleSummaryIndex

https://github.com/llvm/llvm-project/pull/87597


More information about the llvm-commits mailing list