[llvm] [DebugInfo][ObjectYAML] Remove duplicate "Flags" field from LabelSym (PR #88194)

via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 14:00:34 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-objectyaml

Author: None (nikitalita)

<details>
<summary>Changes</summary>

There was a duplicate flags field mistakenly left in LabelSym. [LabelSym only has one flags field](https://github.com/microsoft/microsoft-pdb/blob/805655a28bd8198004be2ac27e6e0290121a5e89/include/cvinfo.h#L3806

---
Full diff: https://github.com/llvm/llvm-project/pull/88194.diff


1 Files Affected:

- (modified) llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp (-1) 


``````````diff
diff --git a/llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp b/llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp
index 64e1a58aa71a8a..e1d2700623ec3c 100644
--- a/llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp
+++ b/llvm/lib/ObjectYAML/CodeViewYAMLSymbols.cpp
@@ -467,7 +467,6 @@ template <> void SymbolRecordImpl<LabelSym>::map(IO &IO) {
   IO.mapOptional("Offset", Symbol.CodeOffset, 0U);
   IO.mapOptional("Segment", Symbol.Segment, uint16_t(0));
   IO.mapRequired("Flags", Symbol.Flags);
-  IO.mapRequired("Flags", Symbol.Flags);
   IO.mapRequired("DisplayName", Symbol.Name);
 }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/88194


More information about the llvm-commits mailing list