[llvm] [docs] Fix broken link in Benchmarking docs (PR #88117)

Youngsuk Kim via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 9 09:16:22 PDT 2024


https://github.com/JOE1994 updated https://github.com/llvm/llvm-project/pull/88117

>From 262d8ef8838da659f2cd421495f9aa49f3290d1e Mon Sep 17 00:00:00 2001
From: Youngsuk Kim <joseph942010 at gmail.com>
Date: Tue, 9 Apr 2024 08:30:21 -0400
Subject: [PATCH 1/2] [docs] Fix broken link in Benchmarking docs

Fixes #58813
---
 llvm/docs/Benchmarking.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/docs/Benchmarking.rst b/llvm/docs/Benchmarking.rst
index 0f88db745a6862..1d1f6e171cf934 100644
--- a/llvm/docs/Benchmarking.rst
+++ b/llvm/docs/Benchmarking.rst
@@ -10,8 +10,8 @@ For benchmarking a patch we want to reduce all possible sources of
 noise as much as possible. How to do that is very OS dependent.
 
 Note that low noise is required, but not sufficient. It does not
-exclude measurement bias. See
-https://www.cis.upenn.edu/~cis501/papers/producing-wrong-data.pdf for
+exclude measurement bias. See `"Producing Wrong Data Without Doing Anything Obviously Wrong!" by Mytkowicz,
+ Diwan, Hauswith and Sweeney (ASPLOS 2009) <https://users.cs.northwestern.edu/~robby/courses/322-2013-spring/mytkowicz-wrong-data.pdf>`_ for
 example.
 
 General

>From 7286b4d3ec1ed1d66bc50df16a9337b36dec1b8b Mon Sep 17 00:00:00 2001
From: Youngsuk Kim <youngsuk.kim at hpe.com>
Date: Tue, 9 Apr 2024 11:15:29 -0500
Subject: [PATCH 2/2] Remove odd indentation to avoid sphinx-build error

---
 llvm/docs/Benchmarking.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/llvm/docs/Benchmarking.rst b/llvm/docs/Benchmarking.rst
index 1d1f6e171cf934..7deb221446067f 100644
--- a/llvm/docs/Benchmarking.rst
+++ b/llvm/docs/Benchmarking.rst
@@ -10,9 +10,9 @@ For benchmarking a patch we want to reduce all possible sources of
 noise as much as possible. How to do that is very OS dependent.
 
 Note that low noise is required, but not sufficient. It does not
-exclude measurement bias. See `"Producing Wrong Data Without Doing Anything Obviously Wrong!" by Mytkowicz,
- Diwan, Hauswith and Sweeney (ASPLOS 2009) <https://users.cs.northwestern.edu/~robby/courses/322-2013-spring/mytkowicz-wrong-data.pdf>`_ for
-example.
+exclude measurement bias.
+See `"Producing Wrong Data Without Doing Anything Obviously Wrong!" by Mytkowicz, Diwan, Hauswith and Sweeney (ASPLOS 2009) <https://users.cs.northwestern.edu/~robby/courses/322-2013-spring/mytkowicz-wrong-data.pdf>`_
+for example.
 
 General
 ================================



More information about the llvm-commits mailing list