jh7370 wrote: @ysyeda, is this ready to review now? Please post to say it is, as I don't have time to go through and check whether you've addressed all my points or to guess that you think you have! https://github.com/llvm/llvm-project/pull/75971