[llvm] [memprof] Use static instead of anonymous namespaces (PR #87889)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 6 11:39:44 PDT 2024
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/87889
This patch replaces anonymous namespaces with static as per LLVM
Coding Standards.
>From 573c850ae4480127ea1111cd84071191411e5b1d Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sat, 6 Apr 2024 02:47:38 -0700
Subject: [PATCH] [memprof] Use static instead of anonymous namespaces
This patch replaces anonymous namespaces with static as per LLVM
Coding Standards.
---
llvm/lib/ProfileData/MemProf.cpp | 32 ++++++++++++--------------------
1 file changed, 12 insertions(+), 20 deletions(-)
diff --git a/llvm/lib/ProfileData/MemProf.cpp b/llvm/lib/ProfileData/MemProf.cpp
index ac0a8702c3f9cf..96aeedf2e6913e 100644
--- a/llvm/lib/ProfileData/MemProf.cpp
+++ b/llvm/lib/ProfileData/MemProf.cpp
@@ -10,8 +10,7 @@
namespace llvm {
namespace memprof {
-namespace {
-size_t serializedSizeV0(const IndexedAllocationInfo &IAI) {
+static size_t serializedSizeV0(const IndexedAllocationInfo &IAI) {
size_t Size = 0;
// The number of frames to serialize.
Size += sizeof(uint64_t);
@@ -22,7 +21,7 @@ size_t serializedSizeV0(const IndexedAllocationInfo &IAI) {
return Size;
}
-size_t serializedSizeV2(const IndexedAllocationInfo &IAI) {
+static size_t serializedSizeV2(const IndexedAllocationInfo &IAI) {
size_t Size = 0;
// The CallStackId
Size += sizeof(CallStackId);
@@ -30,7 +29,6 @@ size_t serializedSizeV2(const IndexedAllocationInfo &IAI) {
Size += PortableMemInfoBlock::serializedSize();
return Size;
}
-} // namespace
size_t IndexedAllocationInfo::serializedSize(IndexedVersion Version) const {
switch (Version) {
@@ -43,8 +41,7 @@ size_t IndexedAllocationInfo::serializedSize(IndexedVersion Version) const {
llvm_unreachable("unsupported MemProf version");
}
-namespace {
-size_t serializedSizeV0(const IndexedMemProfRecord &Record) {
+static size_t serializedSizeV0(const IndexedMemProfRecord &Record) {
size_t Result = sizeof(GlobalValue::GUID);
for (const IndexedAllocationInfo &N : Record.AllocSites)
Result += N.serializedSize(Version0);
@@ -59,7 +56,7 @@ size_t serializedSizeV0(const IndexedMemProfRecord &Record) {
return Result;
}
-size_t serializedSizeV2(const IndexedMemProfRecord &Record) {
+static size_t serializedSizeV2(const IndexedMemProfRecord &Record) {
size_t Result = sizeof(GlobalValue::GUID);
for (const IndexedAllocationInfo &N : Record.AllocSites)
Result += N.serializedSize(Version2);
@@ -70,7 +67,6 @@ size_t serializedSizeV2(const IndexedMemProfRecord &Record) {
Result += Record.CallSiteIds.size() * sizeof(CallStackId);
return Result;
}
-} // namespace
size_t IndexedMemProfRecord::serializedSize(IndexedVersion Version) const {
switch (Version) {
@@ -83,9 +79,8 @@ size_t IndexedMemProfRecord::serializedSize(IndexedVersion Version) const {
llvm_unreachable("unsupported MemProf version");
}
-namespace {
-void serializeV0(const IndexedMemProfRecord &Record,
- const MemProfSchema &Schema, raw_ostream &OS) {
+static void serializeV0(const IndexedMemProfRecord &Record,
+ const MemProfSchema &Schema, raw_ostream &OS) {
using namespace support;
endian::Writer LE(OS, llvm::endianness::little);
@@ -107,8 +102,8 @@ void serializeV0(const IndexedMemProfRecord &Record,
}
}
-void serializeV2(const IndexedMemProfRecord &Record,
- const MemProfSchema &Schema, raw_ostream &OS) {
+static void serializeV2(const IndexedMemProfRecord &Record,
+ const MemProfSchema &Schema, raw_ostream &OS) {
using namespace support;
endian::Writer LE(OS, llvm::endianness::little);
@@ -124,7 +119,6 @@ void serializeV2(const IndexedMemProfRecord &Record,
for (const auto &CSId : Record.CallSiteIds)
LE.write<CallStackId>(CSId);
}
-} // namespace
void IndexedMemProfRecord::serialize(const MemProfSchema &Schema,
raw_ostream &OS, IndexedVersion Version) {
@@ -140,9 +134,8 @@ void IndexedMemProfRecord::serialize(const MemProfSchema &Schema,
llvm_unreachable("unsupported MemProf version");
}
-namespace {
-IndexedMemProfRecord deserializeV0(const MemProfSchema &Schema,
- const unsigned char *Ptr) {
+static IndexedMemProfRecord deserializeV0(const MemProfSchema &Schema,
+ const unsigned char *Ptr) {
using namespace support;
IndexedMemProfRecord Record;
@@ -185,8 +178,8 @@ IndexedMemProfRecord deserializeV0(const MemProfSchema &Schema,
return Record;
}
-IndexedMemProfRecord deserializeV2(const MemProfSchema &Schema,
- const unsigned char *Ptr) {
+static IndexedMemProfRecord deserializeV2(const MemProfSchema &Schema,
+ const unsigned char *Ptr) {
using namespace support;
IndexedMemProfRecord Record;
@@ -214,7 +207,6 @@ IndexedMemProfRecord deserializeV2(const MemProfSchema &Schema,
return Record;
}
-} // namespace
IndexedMemProfRecord
IndexedMemProfRecord::deserialize(const MemProfSchema &Schema,
More information about the llvm-commits
mailing list