[llvm] fe45029 - [cmake] Back out of making unsupported `-no_exported_symbols` linker a
Cyndy Ishida via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 5 14:50:38 PDT 2024
Author: Cyndy Ishida
Date: 2024-04-05T14:50:19-07:00
New Revision: fe45029dbdee6b3df2dbeaed17c9dd598ec511f2
URL: https://github.com/llvm/llvm-project/commit/fe45029dbdee6b3df2dbeaed17c9dd598ec511f2
DIFF: https://github.com/llvm/llvm-project/commit/fe45029dbdee6b3df2dbeaed17c9dd598ec511f2.diff
LOG: [cmake] Back out of making unsupported `-no_exported_symbols` linker a
fatal error for now
Appeases build bots while being investigated.
Added:
Modified:
llvm/cmake/modules/AddLLVM.cmake
Removed:
################################################################################
diff --git a/llvm/cmake/modules/AddLLVM.cmake b/llvm/cmake/modules/AddLLVM.cmake
index f8a17f645e25ba..81398ddb5c92e3 100644
--- a/llvm/cmake/modules/AddLLVM.cmake
+++ b/llvm/cmake/modules/AddLLVM.cmake
@@ -1038,14 +1038,9 @@ macro(add_llvm_executable name)
add_llvm_symbol_exports( ${name} ${LLVM_EXPORTED_SYMBOL_FILE} )
endif(LLVM_EXPORTED_SYMBOL_FILE)
- if (NOT LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES)
- if(LLVM_LINKER_SUPPORTS_NO_EXPORTED_SYMBOLS)
+ if (NOT LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES AND LLVM_LINKER_SUPPORTS_NO_EXPORTED_SYMBOLS)
set_property(TARGET ${name} APPEND_STRING PROPERTY
LINK_FLAGS " -Wl,-no_exported_symbols")
- else()
- message(FATAL_ERROR
- "LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES cannot be disabled when linker does not support \"-no_exported_symbols\"")
- endif()
endif()
if (LLVM_LINK_LLVM_DYLIB AND NOT ARG_DISABLE_LLVM_LINK_LLVM_DYLIB)
More information about the llvm-commits
mailing list