[llvm] f09f9bc - [X86] Add TODO to remove getGSScalarCost and use BaseT / getCommonMaskedMemoryOpCost directly

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 5 05:16:46 PDT 2024


Author: Simon Pilgrim
Date: 2024-04-05T13:16:27+01:00
New Revision: f09f9bc0aafc1e9d0670b4a995ad5f610fc3c7bc

URL: https://github.com/llvm/llvm-project/commit/f09f9bc0aafc1e9d0670b4a995ad5f610fc3c7bc
DIFF: https://github.com/llvm/llvm-project/commit/f09f9bc0aafc1e9d0670b4a995ad5f610fc3c7bc.diff

LOG: [X86] Add TODO to remove getGSScalarCost and use BaseT /  getCommonMaskedMemoryOpCost directly

There are only a few differences in the use of AddressSpace and getScalarizationOverhead that need to be handled.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86TargetTransformInfo.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86TargetTransformInfo.cpp b/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
index 099abbec3e6e4c..5d1810b5bc2c6f 100644
--- a/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
+++ b/llvm/lib/Target/X86/X86TargetTransformInfo.cpp
@@ -5773,6 +5773,7 @@ InstructionCost X86TTIImpl::getGSVectorCost(unsigned Opcode,
 /// VariableMask - The mask is non-constant at compile time.
 /// Alignment - Alignment for one element.
 /// AddressSpace - pointer[s] address space.
+/// TODO: Remove this and use getCommonMaskedMemoryOpCost directly.
 InstructionCost X86TTIImpl::getGSScalarCost(unsigned Opcode,
                                             TTI::TargetCostKind CostKind,
                                             Type *SrcVTy, bool VariableMask,


        


More information about the llvm-commits mailing list