[llvm] goldsteinn/or xor no invertible (PR #87705)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 4 13:39:27 PDT 2024
https://github.com/goldsteinn created https://github.com/llvm/llvm-project/pull/87705
- **[ValueTracking] Add tests for `xor`/`disjoint or` in `getInvertibleOperands`; NFC**
- **[ValueTracking] Add support for `xor`/`disjoint or` in `getInvertibleOperands`**
>From c77b2c66cc8a73e5bf46e48c2b80cb80f13d5e39 Mon Sep 17 00:00:00 2001
From: Noah Goldstein <goldstein.w.n at gmail.com>
Date: Wed, 3 Apr 2024 21:41:47 -0500
Subject: [PATCH 1/2] [ValueTracking] Add tests for `xor`/`disjoint or` in
`getInvertibleOperands`; NFC
---
llvm/test/Transforms/InstSimplify/icmp.ll | 94 ++++++++++++++++++++++-
1 file changed, 93 insertions(+), 1 deletion(-)
diff --git a/llvm/test/Transforms/InstSimplify/icmp.ll b/llvm/test/Transforms/InstSimplify/icmp.ll
index 3109768bdfe005..a66f7cb879ef9d 100644
--- a/llvm/test/Transforms/InstSimplify/icmp.ll
+++ b/llvm/test/Transforms/InstSimplify/icmp.ll
@@ -270,7 +270,7 @@ define i1 @load_ptr(ptr %p) {
define i1 @load_ptr_null_valid(ptr %p) null_pointer_is_valid {
; CHECK-LABEL: @load_ptr_null_valid(
-; CHECK-NEXT: [[LOAD_P:%.*]] = load ptr, ptr [[P:%.*]], align 8, !dereferenceable !0
+; CHECK-NEXT: [[LOAD_P:%.*]] = load ptr, ptr [[P:%.*]], align 8, !dereferenceable [[META0:![0-9]+]]
; CHECK-NEXT: [[R:%.*]] = icmp ne ptr [[LOAD_P]], null
; CHECK-NEXT: ret i1 [[R]]
;
@@ -278,3 +278,95 @@ define i1 @load_ptr_null_valid(ptr %p) null_pointer_is_valid {
%r = icmp ne ptr %load_p, null
ret i1 %r
}
+
+define i1 @non_eq_disjoint_or_common_op(i8 %x, i8 %y, i8 %ww, i8 %a) {
+; CHECK-LABEL: @non_eq_disjoint_or_common_op(
+; CHECK-NEXT: [[W:%.*]] = add nuw i8 [[WW:%.*]], 1
+; CHECK-NEXT: [[Z:%.*]] = add i8 [[Y:%.*]], [[W]]
+; CHECK-NEXT: [[XY:%.*]] = or disjoint i8 [[X:%.*]], [[Y]]
+; CHECK-NEXT: [[XZ:%.*]] = or disjoint i8 [[X]], [[Z]]
+; CHECK-NEXT: [[AXY:%.*]] = add i8 [[A:%.*]], [[XY]]
+; CHECK-NEXT: [[AXZ:%.*]] = add i8 [[A]], [[XZ]]
+; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AXY]], [[AXZ]]
+; CHECK-NEXT: ret i1 [[R]]
+;
+ %w = add nuw i8 %ww, 1
+ %z = add i8 %y, %w
+
+ %xy = or disjoint i8 %x, %y
+ %xz = or disjoint i8 %x, %z
+
+ %axy = add i8 %a, %xy
+ %axz = add i8 %a, %xz
+ %r = icmp eq i8 %axy, %axz
+ ret i1 %r
+}
+
+define i1 @non_eq_disjoint_or_common_op_fail(i8 %x, i8 %y, i8 %ww, i8 %a) {
+; CHECK-LABEL: @non_eq_disjoint_or_common_op_fail(
+; CHECK-NEXT: [[W:%.*]] = add nuw i8 [[WW:%.*]], 1
+; CHECK-NEXT: [[Z:%.*]] = add i8 [[Y:%.*]], [[W]]
+; CHECK-NEXT: [[XY:%.*]] = or i8 [[X:%.*]], [[Y]]
+; CHECK-NEXT: [[XZ:%.*]] = or disjoint i8 [[X]], [[Z]]
+; CHECK-NEXT: [[AXY:%.*]] = add i8 [[A:%.*]], [[XY]]
+; CHECK-NEXT: [[AXZ:%.*]] = add i8 [[A]], [[XZ]]
+; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AXY]], [[AXZ]]
+; CHECK-NEXT: ret i1 [[R]]
+;
+ %w = add nuw i8 %ww, 1
+ %z = add i8 %y, %w
+
+ %xy = or i8 %x, %y
+ %xz = or disjoint i8 %x, %z
+
+ %axy = add i8 %a, %xy
+ %axz = add i8 %a, %xz
+ %r = icmp eq i8 %axy, %axz
+ ret i1 %r
+}
+
+define i1 @non_eq_xor_common_op(i8 %x, i8 %y, i8 %ww, i8 %a) {
+; CHECK-LABEL: @non_eq_xor_common_op(
+; CHECK-NEXT: [[W:%.*]] = add nuw i8 [[WW:%.*]], 1
+; CHECK-NEXT: [[Z:%.*]] = add i8 [[Y:%.*]], [[W]]
+; CHECK-NEXT: [[XY:%.*]] = xor i8 [[Y]], [[X:%.*]]
+; CHECK-NEXT: [[XZ:%.*]] = xor i8 [[X]], [[Z]]
+; CHECK-NEXT: [[AXY:%.*]] = add i8 [[A:%.*]], [[XY]]
+; CHECK-NEXT: [[AXZ:%.*]] = add i8 [[A]], [[XZ]]
+; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AXY]], [[AXZ]]
+; CHECK-NEXT: ret i1 [[R]]
+;
+ %w = add nuw i8 %ww, 1
+ %z = add i8 %y, %w
+
+ %xy = xor i8 %y, %x
+ %xz = xor i8 %x, %z
+
+ %axy = add i8 %a, %xy
+ %axz = add i8 %a, %xz
+ %r = icmp eq i8 %axy, %axz
+ ret i1 %r
+}
+
+define i1 @non_eq_xor_common_op_fail(i8 %x, i8 %y, i8 %ww, i8 %a) {
+; CHECK-LABEL: @non_eq_xor_common_op_fail(
+; CHECK-NEXT: [[W:%.*]] = add nsw i8 [[WW:%.*]], 1
+; CHECK-NEXT: [[Z:%.*]] = add i8 [[Y:%.*]], [[W]]
+; CHECK-NEXT: [[XY:%.*]] = xor i8 [[Y]], [[X:%.*]]
+; CHECK-NEXT: [[XZ:%.*]] = xor i8 [[X]], [[Z]]
+; CHECK-NEXT: [[AXY:%.*]] = add i8 [[A:%.*]], [[XY]]
+; CHECK-NEXT: [[AXZ:%.*]] = add i8 [[A]], [[XZ]]
+; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AXY]], [[AXZ]]
+; CHECK-NEXT: ret i1 [[R]]
+;
+ %w = add nsw i8 %ww, 1
+ %z = add i8 %y, %w
+
+ %xy = xor i8 %y, %x
+ %xz = xor i8 %x, %z
+
+ %axy = add i8 %a, %xy
+ %axz = add i8 %a, %xz
+ %r = icmp eq i8 %axy, %axz
+ ret i1 %r
+}
>From 56c6ff80bbd0b843585e24846997369eb3931fa2 Mon Sep 17 00:00:00 2001
From: Noah Goldstein <goldstein.w.n at gmail.com>
Date: Wed, 3 Apr 2024 17:40:03 -0500
Subject: [PATCH 2/2] [ValueTracking] Add support for `xor`/`disjoint or` in
`getInvertibleOperands`
This strengthens our `isKnownNonEqual` logic with some fairly
trivial cases.
Proofs: https://alive2.llvm.org/ce/z/4pxRTj
---
llvm/lib/Analysis/ValueTracking.cpp | 15 ++++++++++++++-
llvm/test/Transforms/InstSimplify/icmp.ll | 18 ++----------------
2 files changed, 16 insertions(+), 17 deletions(-)
diff --git a/llvm/lib/Analysis/ValueTracking.cpp b/llvm/lib/Analysis/ValueTracking.cpp
index 5ad4da43bca7db..885f4b0907ea6b 100644
--- a/llvm/lib/Analysis/ValueTracking.cpp
+++ b/llvm/lib/Analysis/ValueTracking.cpp
@@ -3004,7 +3004,20 @@ getInvertibleOperands(const Operator *Op1,
switch (Op1->getOpcode()) {
default:
break;
- case Instruction::Add:
+ case Instruction::Or:
+ if (!cast<PossiblyDisjointInst>(Op1)->isDisjoint() ||
+ !cast<PossiblyDisjointInst>(Op2)->isDisjoint())
+ break;
+ [[fallthrough]];
+ case Instruction::Xor:
+ case Instruction::Add: {
+ Value *Other;
+ if (match(Op2, m_c_BinOp(m_Specific(Op1->getOperand(0)), m_Value(Other))))
+ return std::make_pair(Op1->getOperand(1), Other);
+ if (match(Op2, m_c_BinOp(m_Specific(Op1->getOperand(1)), m_Value(Other))))
+ return std::make_pair(Op1->getOperand(0), Other);
+ break;
+ }
case Instruction::Sub:
if (Op1->getOperand(0) == Op2->getOperand(0))
return getOperands(1);
diff --git a/llvm/test/Transforms/InstSimplify/icmp.ll b/llvm/test/Transforms/InstSimplify/icmp.ll
index a66f7cb879ef9d..d1799098115496 100644
--- a/llvm/test/Transforms/InstSimplify/icmp.ll
+++ b/llvm/test/Transforms/InstSimplify/icmp.ll
@@ -281,14 +281,7 @@ define i1 @load_ptr_null_valid(ptr %p) null_pointer_is_valid {
define i1 @non_eq_disjoint_or_common_op(i8 %x, i8 %y, i8 %ww, i8 %a) {
; CHECK-LABEL: @non_eq_disjoint_or_common_op(
-; CHECK-NEXT: [[W:%.*]] = add nuw i8 [[WW:%.*]], 1
-; CHECK-NEXT: [[Z:%.*]] = add i8 [[Y:%.*]], [[W]]
-; CHECK-NEXT: [[XY:%.*]] = or disjoint i8 [[X:%.*]], [[Y]]
-; CHECK-NEXT: [[XZ:%.*]] = or disjoint i8 [[X]], [[Z]]
-; CHECK-NEXT: [[AXY:%.*]] = add i8 [[A:%.*]], [[XY]]
-; CHECK-NEXT: [[AXZ:%.*]] = add i8 [[A]], [[XZ]]
-; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AXY]], [[AXZ]]
-; CHECK-NEXT: ret i1 [[R]]
+; CHECK-NEXT: ret i1 false
;
%w = add nuw i8 %ww, 1
%z = add i8 %y, %w
@@ -327,14 +320,7 @@ define i1 @non_eq_disjoint_or_common_op_fail(i8 %x, i8 %y, i8 %ww, i8 %a) {
define i1 @non_eq_xor_common_op(i8 %x, i8 %y, i8 %ww, i8 %a) {
; CHECK-LABEL: @non_eq_xor_common_op(
-; CHECK-NEXT: [[W:%.*]] = add nuw i8 [[WW:%.*]], 1
-; CHECK-NEXT: [[Z:%.*]] = add i8 [[Y:%.*]], [[W]]
-; CHECK-NEXT: [[XY:%.*]] = xor i8 [[Y]], [[X:%.*]]
-; CHECK-NEXT: [[XZ:%.*]] = xor i8 [[X]], [[Z]]
-; CHECK-NEXT: [[AXY:%.*]] = add i8 [[A:%.*]], [[XY]]
-; CHECK-NEXT: [[AXZ:%.*]] = add i8 [[A]], [[XZ]]
-; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[AXY]], [[AXZ]]
-; CHECK-NEXT: ret i1 [[R]]
+; CHECK-NEXT: ret i1 false
;
%w = add nuw i8 %ww, 1
%z = add i8 %y, %w
More information about the llvm-commits
mailing list