[llvm] lit_test : check if there is already a deps key in kwargs (PR #87290)

Jordan Rupprecht via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 15:31:46 PDT 2024


================
@@ -35,7 +35,7 @@ def lit_test(
         args = args + ["-v"] + ["$(execpath %s)" % src for src in srcs],
         data = data + srcs,
         legacy_create_init = False,
-        deps = [Label("//llvm:lit")],
+        deps = [Label("//llvm:lit")] + kwargs.pop("deps", []),
----------------
rupprecht wrote:

Instead of `pop()` here, can you add a `deps` param to the method and follow the pattern as for args/data?

```
    deps = deps or []

    native.py_test(
        ...
        deps = deps + [Label("//llvm:lit")],
    )
````


https://github.com/llvm/llvm-project/pull/87290


More information about the llvm-commits mailing list