[llvm] [memprof] Add MemProf version (PR #86414)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 13:07:19 PDT 2024


kazutakahirata wrote:

> Can you take a look?

@dyung Do you get similar errors on `llvm/lib/ProfileData/InstrProfWriter.cpp`?

At `llvm/lib/ProfileData/InstrProfReader.cpp:1255`, the types of the arguments to `formatv` are:

1. `const char[80]`
2. `const uint64_t`
3. `const uint64_t`
4. `const uint64_t`

At `llvm/lib/ProfileData/InstrProfWriter.cpp:538`, the types of the arguments to `formatv` are:

1. `const char[80]`
2. `memprof::IndexedVersion` (whose underlying type is `uint64_t`)
3. `const uint64_t`
4. `const uint64_t`

I am guessing that if `const uint64_t` is problematic, `InstrProfWriter.cpp` should trigger similar errors.

With all that said, it's possible for your build system to terminate the build upon the first error.  It may not have a chance to get to `InstrProfWriter.cpp` if it encounters an error with `InstrProfReader.cpp` first.

https://github.com/llvm/llvm-project/pull/86414


More information about the llvm-commits mailing list