[compiler-rt] dc0cb17 - [msan] Nit: use init_origins parameter instead of __msan_get_track_origins() in InitShadowWithReExec (#86994)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 31 18:49:35 PDT 2024
Author: Thurston Dang
Date: 2024-03-31T18:49:31-07:00
New Revision: dc0cb17241aeff205a0c3a7cc4e790afab7484dd
URL: https://github.com/llvm/llvm-project/commit/dc0cb17241aeff205a0c3a7cc4e790afab7484dd
DIFF: https://github.com/llvm/llvm-project/commit/dc0cb17241aeff205a0c3a7cc4e790afab7484dd.diff
LOG: [msan] Nit: use init_origins parameter instead of __msan_get_track_origins() in InitShadowWithReExec (#86994)
This fixes a nit I had accidentally introduced in
https://github.com/llvm/llvm-project/pull/85142
I don't think the value of __msan_get_track_origins() will change
between the start and end of InitShadowWithReExec, but it's cleaner to
use the parameter.
Added:
Modified:
compiler-rt/lib/msan/msan_linux.cpp
Removed:
################################################################################
diff --git a/compiler-rt/lib/msan/msan_linux.cpp b/compiler-rt/lib/msan/msan_linux.cpp
index cd2d9f5c720c57..c68aec60ae13ea 100644
--- a/compiler-rt/lib/msan/msan_linux.cpp
+++ b/compiler-rt/lib/msan/msan_linux.cpp
@@ -175,7 +175,7 @@ bool InitShadowWithReExec(bool init_origins) {
// Start with dry run: check layout is ok, but don't print warnings because
// warning messages will cause tests to fail (even if we successfully re-exec
// after the warning).
- bool success = InitShadow(__msan_get_track_origins(), true);
+ bool success = InitShadow(init_origins, true);
if (!success) {
# if SANITIZER_LINUX
// Perhaps ASLR entropy is too high. If ASLR is enabled, re-exec without it.
@@ -197,7 +197,7 @@ bool InitShadowWithReExec(bool init_origins) {
// The earlier dry run didn't actually map or protect anything. Run again in
// non-dry run mode.
- return success && InitShadow(__msan_get_track_origins(), false);
+ return success && InitShadow(init_origins, false);
}
static void MsanAtExit(void) {
More information about the llvm-commits
mailing list