[llvm] [IR] Use EXPORTAS for ARM64EC mangled symbols with dllexport attribute. (PR #81940)

Haojian Wu via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 31 03:00:33 PDT 2024


================
@@ -18,8 +18,10 @@
 #include "llvm/IR/DerivedTypes.h"
 #include "llvm/IR/Function.h"
 #include "llvm/IR/Module.h"
+#include "llvm/Object/COFF.h"
----------------
hokein wrote:

(this comes up when I tried to fix the upstream bazel build [failure](https://buildkite.com/llvm-project/upstream-bazel/builds/93424))

We seem to introduce a cycle dependency here, in bazel config, we have
- llvm:Core target which includes all lib/IR/* files
- llvm:Object target depends on llvm:Core

This change makes llvm:Core depends on llvm:Object. Can we remove this dependency? We only need `object::getArm64ECDemangledFunctionName` in this file, is it possible (and sensible) to move this inline `getArm64ECDemangledFunctionName` from `COFF.h` to `Mangler.h` or a new file?

https://github.com/llvm/llvm-project/pull/81940


More information about the llvm-commits mailing list