[llvm] [MIPS][CallSiteInfo][NFC] Fill CallSiteInfo only when needed (PR #86847)

Paul Kirth via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 30 08:16:37 PDT 2024


================
@@ -3381,7 +3381,7 @@ MipsTargetLowering::LowerCall(TargetLowering::CallLoweringInfo &CLI,
 
       // Collect CSInfo about which register passes which parameter.
       const TargetOptions &Options = DAG.getTarget().Options;
-      if (Options.SupportsDebugEntryValues)
+      if (Options.EmitCallSiteInfo && Options.SupportsDebugEntryValues)
----------------
ilovepi wrote:

Actually, looking at other platforms, it seems like it’s more common to only do this when EmitCallSiteInfo is true. A comment on the previous phabricator patch mentions this. 

If MIPS requires CallSiteInfo for debugging for some reason, this can be an OR expression. 

Can you update the patch to match the other platforms here?

https://github.com/llvm/llvm-project/pull/86847


More information about the llvm-commits mailing list