https://github.com/coopp approved this pull request. Looks good to me. I'll second Justin's comment about finding someone with SPIR-V knowledge to peek as well. https://github.com/llvm/llvm-project/pull/86844