[llvm] [speculative-execution] Hoists debug values unnecessarily. (PR #85782)

Orlando Cazalet-Hyams via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 28 03:41:32 PDT 2024


https://github.com/OCHyams approved this pull request.

LGTM, this change sounds right in isolation. I have a slight worry that this could lead to missing debug records if everything else in the block is hoisted, and then that block (containing only debug records) is deleted later. But ultimately that probably shouldn't be a concern for this pass; passes that delete blocks are responsible for making sure the right thing happens in those cases.

https://github.com/llvm/llvm-project/pull/85782


More information about the llvm-commits mailing list