[llvm] [InlineCost] Disable cost-benefit when sample based PGO is used (PR #86626)

via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 27 22:50:35 PDT 2024


WenleiHe wrote:

Thanks for working on profile maintenance. I don't think the patches you mentioned are going to change the results meaningfully. Is there a particular reason you want this to be default on? As others mentioned, you can just turn it on as needed. 

I'd also like to share some general feedbacks: 1) landing default changes like the original patch generally has a high bar. 2) the way it was done, without perf numbers, and without stakeholder review before landing is not how things are usually done. 

https://github.com/llvm/llvm-project/pull/86626


More information about the llvm-commits mailing list